bug: only account for if the top of an elemnet is out of view

We were originally checking if the whole element was out of view, but
due to the nested nature of things, this was always. Instead we only
check to see if the top of the element is out of view. If it is, we
scroll it into view otherwise we assume that enough of the node is
visible for you.

diff --git a/public/assets/bundle.js b/public/assets/bundle.js
index ae072e4fac40d3a45b5f7e0df776b525a3615939..e87375acd7acfa2ea0b6968ce758903fe9686585 100644 (file)
--- a/public/assets/bundle.js
+++ b/public/assets/bundle.js
@@ -18690,7 +18690,7 @@ function isVisible(element) {
     const rect = element.getBoundingClientRect();
     return (rect.top >= 0 &&
         rect.left >= 0 &&
-        rect.bottom <= (window.innerHeight || document.documentElement.clientHeight) &&
+        rect.top <= (window.innerHeight || document.documentElement.clientHeight) &&
         rect.right <= (window.innerWidth || document.documentElement.clientWidth));
 }
 exports.isVisible = isVisible;

diff --git a/src/dom.ts b/src/dom.ts
index 481c5edcb84a2c178c81c1cc5878a666fa9e0390..3ee623ba34774ca956c1353ebe1f39e6c67bbfbe 100644 (file)
--- a/src/dom.ts
+++ b/src/dom.ts
@@ -3,7 +3,7 @@ export function isVisible(element: HTMLElement): boolean {
     return (
         rect.top >= 0 &&
         rect.left >= 0 &&
-        rect.bottom <= (window.innerHeight || document.documentElement.clientHeight) &&     
+        rect.top <= (window.innerHeight || document.documentElement.clientHeight) &&     
         rect.right <= (window.innerWidth || document.documentElement.clientWidth)
     );
 }